[DO NOT MERGE YET] add native Typescript support #9412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I've run into the issue that my setup with remix (remix.run) is not capable of handling the esports from the generated js files (even with the support of grpc-web). At first I started working on a patch for grpc-web in order to fix it, however the deeper I dove into that the more it seems that the whole extension is a workaround. js now supports client-to-server streaming natively with the newly launched fetch upload streaming. Therefor I want to make this patch to update protoc to generate proper modern files To do this I want to: - generate typescript files for the messages and client stubs. - update the npm library to be fitting a more modern standard and implement the client side streaming. my goal is to just do the typescript part as not to blow up the scope for me to do personally since I am way out of my depth in c++. For this reason I am hoping for support to properly implement this
|
Thanks for opening the PR, I wanted to let you know were not planning to support TypeScript in this way with this plugin so I wanted to set your expectations about merging this. Feel free to fork and maintain a plugin that meets your needs, but it won't be something we can devote resources to supporting at the moment. |
|
Is updating the javascript that is produced to modern syntax still an option? |
|
I'm closing this as I have found success with the protoc-gen-ts plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've run into the issue that my setup with remix (remix.run) is not capable of handling the esports from the generated js files (even with the support of grpc-web).
At first I started working on a patch for grpc-web in order to fix it, however the deeper I dove into that the more it seems that the whole extension is a workaround.
js now supports client-to-server streaming natively with the newly launched fetch upload streaming.
Therefor I want to make this patch to update protoc to generate proper modern files
To do this I want to:
my goal is to just do the typescript part as not to blow up the scope for me to do personally since I am way out of my depth in c++. For this reason I am hoping for support to properly implement this