-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.10 #9034
Add python 3.10 #9034
Conversation
@busunkim96 Thank you for adding this Python 3.10 test coverage. LGTM if you can just fix the merge conflicts. We will need to push the Docker image but I can easily do that once this is merged. |
"Programming Language :: Python :: 3.3", | ||
"Programming Language :: Python :: 3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acozzette I removed 3.3 and 3.4 to match the python_requires>=3.5
below.
tests.sh
Outdated
@@ -427,6 +431,11 @@ build_python39_cpp() { | |||
build_python_cpp_version py39-cpp | |||
} | |||
|
|||
build_python310_cpp() { | |||
build_python_cpp_version py39-cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say py310-cpp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
The Python 3.10 release is scheduled for next Monday, 2021-10-04. https://www.python.org/dev/peps/pep-0619/
Because 3.10 is still technically a release candidate, the imagepython:3.10-buster
does not yet exist, but should soon.python:3.10-buster now exists: https://hub.docker.com/_/python
Intended to be reviewed together with Kokoro config change in internal changelist 399739838.