js: use commonjs_strict for well-known types #8955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating JS code for .proto files which included well-known types with the commonjs_strict import style, the generated code would import generated JS code for the well-known types with the commonjs import style (located in the google-protobuf NPM package). This causes several issues as discussed in #7778. This CL changes this so when using commonjs_strict, the imported generated JS code for well-known types also uses commonjs_strict. Fixes #7778
|
@acozzette would you mind taking a look at this and maybe review it? Thanks in advance! :) |
|
We are closing all open JavaScript pull requests because the JavaScript implementation is moving to a new repository: https://github.com/protocolbuffers/protobuf-javascript Sorry for the inconvenience but please feel free to reopen the pull request in the new repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating JS code for .proto files which included well-known types
with the commonjs_strict import style, the generated code would import
generated JS code for the well-known types with the commonjs import
style (located in the google-protobuf NPM package). This causes several
issues as discussed in protocolbuffers/protobuf-javascript#25.
This CL changes this so when using commonjs_strict, the imported
generated JS code for well-known types also uses commonjs_strict.
Fixes protocolbuffers/protobuf-javascript#25
Note: currently a folder named "commonjs_strict" is used to save the generated JS code for well-known types. I'm not fully convinced by this, so please let me know if you know how to improve where to store the generated code for the commonjs_strict mode. Thanks!