Remove deprecated version of SetTotalBytesLimit() #8794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been depcated for at least 3 years. Worst (backward incompatible) things happened during this period. I think this method could be safely removed, as the client code fix is trivial.
|
It looks like coded_stream_unittest.cc needs to be updated because it still exercises the deprecated function. |
|
Thanks, Adam. |
|
@georgthegreat Thanks for the cleanup! |
|
|
|
You should use single parameter version instead. |
madisongh
pushed a commit
to OE4T/meta-tegra
that referenced
this pull request
Sep 27, 2021
This is needed because of upgrade version of protobuf from 3.17.x to 3.18.x in meta-openembedded https://git.openembedded.org/meta-openembedded/commit/?id=d7d9597348534b9d93dd7ed8ef49fa2b5c33969d For more details, deprecated version of SetTotalBytesLimit API was removed in PR #8794 (protocolbuffers/protobuf#8794) Signed-off-by: Ilies CHERGUI <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been deprecated for at least 3 years.
Worse backward incompatible things have happened during this period.
I think this method could be safely removed, as the client code fix is trivial.