[csharp] ByteString.CreateCodedInput should use ArraySegment offset and count #8740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd count CreateCodedInput is created from the underlying array behind the ByteString. If this was created from a larger array (via Memory<byte> or ArrayPool etc) then the CodedInput refers to the wrong section of memory. Change is to add the offset and count like the other methods that use the ArraySegment (ToString, ToBase64, WriteTo).
JamesNK
approved these changes
Jun 18, 2021
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateCodedInput is created from the underlying array behind the ByteString.
If this was created from a larger array (via Memory or ArrayPool etc)
then the CodedInput refers to the wrong section of memory.
Change is to add the offset and count like the other methods that use the
ArraySegment (ToString, ToBase64, WriteTo).
Fixup for #7645