-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constinit not working as expected in Visual Studio 2019 Update 16.10 #8690
constinit not working as expected in Visual Studio 2019 Update 16.10 #8690
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
I don't have permission to add label |
Thanks for the patch! will merge after CI finishes |
…_16.10_constinit_broken constinit not working as expected in Visual Studio 2019 Update 16.10
Fixes #8688
Visual Studio 2019 Update 16.10 introduced support for
constinit
for the very first time on May 25th. Unfortunately the way how protobuf uses constinit does not work with Visual Studio msvc compiler. This is a temporary solution to unblock those who updated to latest release of Visual Studio 2019 compiler.