Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed memory bug: properly root repeated/map field when assigning. #8639

Merged
merged 2 commits into from
May 22, 2021
Merged

Fixed memory bug: properly root repeated/map field when assigning. #8639

merged 2 commits into from
May 22, 2021

Commits on May 22, 2021

  1. Fixed memory bug: properly root repeated/map field when assigning. 

    Previously the protobuf extension would not properly root
memory from a repeated field or map when assigning to a
message field (see the attached test case).  This could cause
crashes if the repeated field is subsequently accessed.
    @haberman
    haberman committed May 22, 2021
    Configuration menu
    Copy the full SHA
    f6439a8 View commit details
    Browse the repository at this point in the history

  2. Add accidentally-deleted Ruby test.

    @haberman
    haberman committed May 22, 2021
    Configuration menu
    Copy the full SHA
    6a1e47f View commit details
    Browse the repository at this point in the history