Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constness issue detected by MSVC standard conforming mode #8568

Merged
merged 1 commit into from
May 6, 2021
Merged

Fix constness issue detected by MSVC standard conforming mode #8568

merged 1 commit into from
May 6, 2021

Conversation

georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented May 5, 2021 •
edited
Loading

This is the continuation of #8344

Original error is (formatting is mine):

error C2664: 'PyObject* google::protobuf::python::cdescriptor_pool::SetErrorFromCollector(
  google::protobuf::DescriptorPool::ErrorCollector *,
  char *,
  char*
)': cannot convert argument 3 from 'const char [5]' to 'char *'

@google-cla google-cla bot added the cla: yes label May 5, 2021
@acozzette acozzette merged commit c8389f8 into protocolbuffers:master May 6, 2021
@georgthegreat georgthegreat deleted the patch-1 branch May 6, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgthegreat @acozzette @protobuf-kokoro