Fix -Wsuggest-destructor-override for generated C++ proto classes. #8408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
reviewed
Mar 17, 2021
| @@ -1092,7 +1092,7 @@ void MessageGenerator::GenerateClassDefinition(io::Printer* printer) { | |||
|
|
|||
| format( | |||
| "inline $classname$() : $classname$(nullptr) {}\n" | |||
| "virtual ~$classname$();\n" | |||
| "virtual ~$classname$() override;\n" | |||
There was a problem hiding this comment.
I think as long as we're adding override we can drop the virtual keyword since that is implied. One other thing is would you mind running ./generate_descriptor_proto.sh? That will rebuild the checked-in pb.h and pb.cc files.
|
Thanks, @PatriosTheGreat. |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Fix -Wsuggest-destructor-override for generated C++ proto classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since proto objects inherits Message class with virtual destructor, they need to override it.
This warning was introduced by clang-11 compiler.