-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch on "new" buffer API #8339
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
b1981b6
to
1f8f5cf
Compare
Can anyone watch this PR? |
"Old" buffer API will removed in Python 3.10. This is also fix protocolbuffers#7930.
1f8f5cf
to
01cdbd4
Compare
I fixed warning with deprecation PyEval_CallObject for Python 3.9 @acozzette Can you rerun tests, please? |
Free bonus from switching on "new" buffer API:
@acozzette It looks like another restart is needed :) |
@acozzette, I don't have access for Kokoro build failed. Could you, please, help me to understand failure reasons? |
Here is the error message and the last few log lines before it:
|
These errors are not related to the change in this PR. It looks like something has changed in the build since October 1, 2020 #7927 I removed @acozzette Can you rerun tests, please? |
"Old" buffer API will removed in Python 3.10. This is also fix #7930.