[Protoc] C++ Resolved an issue where NO_DESTROY and CONSTINIT are in incorrect order

[Yuhanun]

According to cppreference: https://en.cppreference.com/w/cpp/language/declarations#Simple_declaration

It should be:
Attributes Specifiers Type Identifier [ = init_value];
not:
Specifiers Attributes Type Identifier [ = init_value];

This pull request solves that.

Issue is shown here:
https://godbolt.org/z/xncqfh

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Yuhanun]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

[mumbleskates]

@Yuhanun There are also a large number of fixable instances of PROTOBUF_CONSTINIT PROTOBUF_ATTRIBUTE_NO_DESTROY in non-generated source files!

[mumbleskates]

see: mumbleskates@30d51ad

[Yuhanun]

@Yuhanun There are also a large number of fixable instances of PROTOBUF_CONSTINIT PROTOBUF_ATTRIBUTE_NO_DESTROY in non-generated source files!

I thought these were generated. I'll fix them as soon as I get to it. How do I make the tests run in the PR?

[Yuhanun]

see: mumbleskates@30d51ad

I'm assuming this means you've fixed it?

Thank you! Please do mention me as contributor if possible.

Nevermind, it's on your own fork.

[Yuhanun]

Pushed these changes to my Fork.

[Yuhanun]

Any update on this? This issue is preventing CLANG from building.

[acozzette]

Thanks for this fix, @Yuhanun.

[Yuhanun]

No worries!