Fix MinGW-w64 build issues. #8286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Windows build with MinGW-w64 compiler. Windows is assumed to always be little endian.
Fix for Windows build with MinGW-w64 compiler which has __has_attribute but has issues with __attribute__((weak)).
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
This comment has been minimized.
This comment has been minimized.
|
Thanks, @brechtsanders. |
aherrmann
added a commit
to tweag/rules_haskell
that referenced
this pull request
Feb 23, 2021
This includes a fix for builds on Windows using mingw. See protocolbuffers/protobuf#8286
aherrmann
added a commit
to tweag/rules_haskell
that referenced
this pull request
Feb 23, 2021
- Adds windows to the bindist pipeline os-matrix. - Specify bash as the shell for the pipeline actions. (Default on Windows would be powershell) - Extend start script to support Windows. - Add CI tag filters to disable unsupported tests on Windows. - A `sh_test`s name must have an extension matching that of `srcs`. ``` ERROR: D:/a/rules_haskell/rules_haskell/tests/BUILD.bazel:134:8: in sh_test rule //tests:test-binary-with-data: Source file is a Windows executable file, target name extension should match source file extension ``` - Use `rule_test_exe` instead of `rule_test` where appropriate. - Disable stack_snapshot lock files on Windows They were pinned on Linux and contain platform specific dependencies, e.g. `unix`. - Update protobuf to 3.15.1 This includes a fix for builds on Windows using mingw. See protocolbuffers/protobuf#8286 - Skip c2hs tests on Windows - Disable tests requiring nm `nm` is not in default `PATH` in Windows. We could obtain it either via `$(NM)` make variable or directl from the `CcToolchainInfo`. - Skip solib test on Windows - Skip runfiles-tree test on Windows - Disable haddock tests on Windows The haddock wrapper needs to be converted to a `sh_binary`. - Skip cabal library test on Windows Bazel builds are not sandboxed on Windows. These tests fail because both Cabal files are visible in the same build actions. - Remove libz.dll.a in GHC bindist, similar to other .dll.a libs. - Disable haskell_import test on Windows - Skip test on Windows that needs rlocation These can be fixed later on by using rlocation instead of expecting files to be available under a hard-coded relative path. - Skip proto test on Windows
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8049