-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: build extensions for arm64-darwin #8232
Conversation
I'm seeing the following error in the "MacOS Ruby Release" test. Perhaps this means we need our macOS build machine to be updated to something that supports aarch64?
|
What is the reason for splitting apart the darwins, instead of just using |
Because there's no such architecture to compile Ruby for. The following command fails:
Previously we just used sed 's/x86_64-darwin-11/universal-darwin/' ~/.rake-compiler/config.yml > "$CROSS_RUBY"
mv "$CROSS_RUBY" ~/.rake-compiler/config.yml |
That's probably old autoconf's problem. Ruby 3.0 builds on my local machine but Ruby 2.7 not. I should have checked that. |
Moreover, in my local machine, it seems to produce x86_64 binaries regardless of
I'll incorporate it into the PR later. |
Any progress on this? I guess we need a googler to do something with this. |
Maybe you could update this PR to just build x86_64 for Darwin, and rely on the installing machine to build for arm64. I.e. just remove the universal-darwin name |
This part was actually easy, I just needed to use |
Sorry for the delay and thanks for the contribution. Everything's passing right now, so going to merge this in! |
@qnighy was this PR suppose produce a |
This PR adds builds for arm64-darwin. It also renames
universal-darwin
back tox86_64-darwin
to avoid confusion. These arch names are already used in nokogiri, so I think it's fine to rename it back to them.See #8231 for a different approach.