Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings issue found in conformance_test_runner#8189 #8190

Merged

Conversation

akjain2052
Copy link
Contributor

Signed-off-by: Abhishek Jain [email protected]

@akjain2052
Copy link
Contributor Author

This is a fix for this issue - [C++] Compiler warnings showing in conformance_test_runner #8189

@akjain2052
Copy link
Contributor Author

Please add label:c++ and release notes:yes

@akjain2052 akjain2052 force-pushed the fix-issue-8189-compiler-warning branch from 03ac7a1 to 3aaffa6 Compare January 8, 2021 05:20
@akjain2052
Copy link
Contributor Author

akjain2052 commented Jan 10, 2021

@TeBoring, Please review the changes, and help to add label:c++ & release notes:yes

@akjain2052
Copy link
Contributor Author

@TeBoring @acozzette Please review the changes, and help to add label:c++ & release notes:yes

@akjain2052 akjain2052 force-pushed the fix-issue-8189-compiler-warning branch from 3aaffa6 to 930815b Compare January 20, 2021 07:12
@akjain2052
Copy link
Contributor Author

Please help to review, and merge this change.

@dlj-NaN dlj-NaN merged commit 0ef575b into protocolbuffers:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants