-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and build for Ruby 3.0 #8134
Conversation
The mentioned PR rake-compiler/rake-compiler-dock#40 is merged. |
The Kokoro builds for Ruby 2.4-2.7 appear to be failing with errors like:
|
@haberman Thanks for invoking the CI. What are the build failures for Ruby 2.4 to 2.7 this time? I'm not privileged to see the kokoro status page by myself... And it seems that the builds for Linux Ruby 3.0 and MacOS Ruby 3.0 are not run. Am I missing something? |
My previous run of the push script failed. I just had it run successfully, so hopefully they will succeed this time. For the Ruby 3.0 build, we probably need to update the job config which lives in the internal google repo. @TeBoring could you take a look? |
Note: grpc merged their Ruby 3.0 build: grpc/grpc#25070 |
Oh no, that Linux Ruby 3.0 failure is a segfault:
|
I wonder if we might want to package this together with: #8184 The SEGV seen in that test should be fixed by the changes in #8184. The old way of GC-rooting everything during the parse was far more complicated and fragile. The changes in #8184 are very extensive and may introduce some bugs that we'll have to work through. But overall it is a large improvement, and is the way of the future. @qnighy could you add your consent for your changes in that PR? |
Merged as part of #8184. Closing. |
Ruby 3.0 has been released. This PR tests protobuf with Ruby 3.0.0 and builds extensions for Ruby 3.0.x.
Waiting for the release of rake-compiler-dock 1.1.0 rake-compiler/rake-compiler-dock#40