-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python 3.9 #8121
add python 3.9 #8121
Conversation
Looks like it needs a |
There is a generic wheel that gets downloaded for python3.9. Is this very different than the one that would be generated solely for py39? |
@mihaimaruseac I believe in many use cases the generic wheel is sufficient. As an example, the Google Cloud client libraries can run their tests with the generic wheel without problems. However, the platform specific wheels are necessary to use the C++ Implementation.
#6214 explains this for 3.8. |
@anandolee 👋 Could I have help with Kokoro? I looked at the logs for the new 3.9 builds and it fails with:
Does a Docker image need to published manually? |
Python39 tests are now passing. Can you fix the distcheck @busunkim96 ? I can not open the error details for somehow... |
@busunkim96 what needs to happen to get the python39 wheel uploaded to PyPI? |
@scotloach A release of protobuf needs to actually be made for the wheels to be published. I'm not on the protobuf team so I'm not sure what their plans are. @anandolee? |
https://pypi.org/project/protobuf/3.15.0rc1/#files has now the python 3.9 release candidate builds. Yet both python 3.8 and 3.9 are missing the Windows builds. I hope they will show up in the final release. The Windows builds for python 3.8 were also missing in v3.14.0, so not entirely sure what's behind it, if there's a plan to build them? |
Modeled after #7009.
Fixes #7978