Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.9 #8121

Merged
merged 2 commits into from
Feb 2, 2021
Merged

add python 3.9 #8121

merged 2 commits into from
Feb 2, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 4, 2020

Modeled after #7009.

Fixes #7978

tests.sh Outdated Show resolved Hide resolved
tests.sh Outdated Show resolved Hide resolved
@komalali
Copy link

Looks like it needs a python label?

@mihaimaruseac
Copy link

There is a generic wheel that gets downloaded for python3.9. Is this very different than the one that would be generated solely for py39?

@busunkim96
Copy link
Contributor Author

@mihaimaruseac I believe in many use cases the generic wheel is sufficient. As an example, the Google Cloud client libraries can run their tests with the generic wheel without problems.

However, the platform specific wheels are necessary to use the C++ Implementation.

There is also a C++ implementation for Python messages via a Python extension for better performance. Implementation type is controlled by an environment variable PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION (valid values: "cpp" and "python"). The default value is currently "python" but will be changed to "cpp" in future release.

#6214 explains this for 3.8.

@busunkim96
Copy link
Contributor Author

@anandolee 👋 Could I have help with Kokoro? I looked at the logs for the new 3.9 builds and it fails with:

+ docker pull protobuftesting/python39_40b2c95dbd62f8d5856cf11b19cad04a8847f2f8
Using default tag: latest
Error response from daemon: pull access denied for protobuftesting/python39_40b2c95dbd62f8d5856cf11b19cad04a8847f2f8, repository does not exist or may require 'docker login'
+ sleep 10
...

Does a Docker image need to published manually?

@busunkim96
Copy link
Contributor Author

@anandolee
Copy link
Contributor

Python39 tests are now passing. Can you fix the distcheck @busunkim96 ? I can not open the error details for somehow...

@gerben-s gerben-s merged commit 10ecb08 into protocolbuffers:master Feb 2, 2021
@busunkim96 busunkim96 deleted the add-39 branch February 2, 2021 16:18
@scotloach
Copy link

@busunkim96 what needs to happen to get the python39 wheel uploaded to PyPI?
https://pypi.org/project/protobuf/#files

@busunkim96
Copy link
Contributor Author

@scotloach A release of protobuf needs to actually be made for the wheels to be published. I'm not on the protobuf team so I'm not sure what their plans are. @anandolee?

@ahtik
Copy link

ahtik commented Feb 11, 2021

https://pypi.org/project/protobuf/3.15.0rc1/#files has now the python 3.9 release candidate builds. Yet both python 3.8 and 3.9 are missing the Windows builds. I hope they will show up in the final release.

The Windows builds for python 3.8 were also missing in v3.14.0, so not entirely sure what's behind it, if there's a plan to build them?

@busunkim96
Copy link
Contributor Author

@ahtik I don't think that was intended. I bumped #7967 which was filed for the missing Windows 3.8 wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError with Python 3.9
10 participants