Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved HasOneof test into GeneratedClassTest.php, to avoid the extra file. #8005

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Moved HasOneof test into GeneratedClassTest.php, to avoid the extra file. #8005

merged 1 commit into from
Nov 4, 2020

Conversation

haberman
Copy link
Member

@haberman haberman commented Nov 4, 2020

Fixes the test broken by #8003

@google-cla google-cla bot added the cla: yes label Nov 4, 2020
@haberman haberman merged commit 7b56ea3 into protocolbuffers:master Nov 4, 2020
@haberman haberman deleted the php-filefix branch December 6, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

Assignees
No one assigned
Labels
cla: yes php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haberman @acozzette @protobuf-kokoro