Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Ruby extensions build #7085

Closed
wants to merge 4 commits into from

Conversation

casperisfine
Copy link
Contributor

Based on #7027

I finally managed to reproduce locally with:

docker run -v $PWD:/tmpfs/src/github/protobuf/ruby -e UID\=1000 -e GID\=1000 -e USER\=kbuilder -e GROUP\=kbuilder -e GEM_PRIVATE_KEY_PASSPHRASE -e ftp_proxy -e http_proxy -e https_proxy -e RCD_HOST_RUBY_PLATFORM\=x86_64-linux -e RCD_HOST_RUBY_VERSION\=2.4.1 -e RCD_IMAGE\=protobuftesting/ruby_rake_compiler_52bbc96c6d72ba1b25e99e19bdcfeb240438566c -w /tmpfs/src/github/protobuf/ruby --rm -i protobuftesting/ruby_rake_compiler_52bbc96c6d72ba1b25e99e19bdcfeb240438566c runas sigfw bash -c 'bundle && IN_DOCKER=true rake cross native gem RUBY_CC_VERSION\=2.7.0:2.6.0:2.5.0:2.4.0:2.3.0]'

Installing bundler just before bundle install like this is not super elegant, but given that I don't have a proper feedback loop, it seems like the most straightforward fix.

@qnighy @haberman

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@casperisfine
Copy link
Contributor Author

@googlebot I consent.

@acozzette
Copy link
Member

@casperisfine I think the CLA bot is having trouble validating that all CLAs are signed because of the commits by @byroot and @qnighy. If they leave comments saying @googlebot I consent then that should solve the problem.

@byroot
Copy link
Contributor

byroot commented Jan 18, 2020

@googlebot I consent.

1 similar comment
@qnighy
Copy link
Contributor

qnighy commented Jan 18, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@haberman
Copy link
Member

Kokoro build appears broken still?

@acozzette acozzette added the ruby label Oct 13, 2021
@acozzette
Copy link
Member

I'm going to close this because I assume it's no longer needed since #7027 was merged.

@acozzette acozzette closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants