Fix js message pivot selection #6813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artiz
changed the title
artiz
changed the title
artiz
changed the title
|
Hi @TeBoring |
|
Ping |
|
Bump! |
|
This looks good to me |
sthagen
added a commit
to sthagen/protocolbuffers-protobuf
that referenced
this pull request
Feb 27, 2020
Fix js message pivot selection (protocolbuffers#6813)
1480c1
reviewed
Feb 27, 2020
| @@ -1217,6 +1217,7 @@ js_EXTRA_DIST= \ | |||
| js/test_bootstrap.js \ | |||
| js/testbinary.proto \ | |||
| js/testempty.proto \ | |||
| js/testlargenumbers.proto | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that protoc compiler incorrectly set field values in proto3 generated message wrappers in JavaScript. Incorrect implementation of jspb.Message.setFieldIgnoringDefault_ could lead to data array corruption or incorrect property value load if field number > 500.
I have prepared simple test case at https://github.com/artiz/google-protobuf-invalid-message-pivot-selection to verify incorrect behavior