Fix for GC of Ruby map frames. #6533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were creating a map decoding frame when starting the *map*, but clearing the GC slot when finishing each *map entry*. This means that the decoding frame could be collected in the meantime.
|
The existing gc test only tests map with one key/value pair. Can we add more key/value pair into the test? |
TeBoring
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were creating a map decoding frame when starting the map,
but clearing the GC slot when finishing each map entry. This
means that the decoding frame could be collected in the meantime.
Hopefully this will fix #6532 (needs to be tested/verified).
I have not verified that this fixes anything yet, but it does seem to correct a correctness error in the previous code.