-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podspec for C++ #6404
Add podspec for C++ #6404
Conversation
@thomasvl - PTAL |
@muxi - The protobuf team will also have to agree to maintain/updating this like they do the objc one with releases. |
Sounds good. We will ask them about it. Thanks! |
@muxi this seems fine to me, so you'll need to get someone on the protobuf team for final sign off on name (i.e. - Protobuf-cc or something else) and also that why want to maintain/publish this with releases. |
@thomasvl - we will get this done. Thank you for the help again Thomas. |
update_version.py
Outdated
@@ -250,6 +250,11 @@ def UpdateObjectiveC(): | |||
r"^ s.version = '.*'$", | |||
" s.version = '%s'" % GetFullVersion(rc_suffix = '-rc'), | |||
line)) | |||
RewriteTextFile('Protobuf-cc.podspec', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc to c++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. Fixed.
Hi there,
and the Protobuf-C++ target doesn't compile.
After digging around looks like this pod does not support the I have 2 questions for you:
Regarding question 2, I managed to compile it by manually adding this search path to
You can do it in the podspec file like so:
But it crashes on startup with the following error:
You can clone this repo to reproduce the issue:
|
I have the same issue, please fix it! |
This is a workaround you can do on your Podfile:
|
No description provided.