Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Protobuf compatible with C# 6 #5445

Merged
3 commits merged into from Dec 11, 2018
Merged

Make Protobuf compatible with C# 6 #5445

3 commits merged into from Dec 11, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2018

Fix internal C# compilation issue.

… == inside it, otherwise it would cause stack overflow
@ObsidianMinor
Copy link
Contributor

You can also set the language version to C# 6 in each project (<LangVersion>6</LangVersion>) to prevent future instances of incompatibility.

@ghost ghost added the kokoro:run label Dec 10, 2018
@ghost
Copy link
Author

ghost commented Dec 10, 2018

You can also set the language version to C# 6 in each project (<LangVersion>6</LangVersion>) to prevent future instances of incompatibility.

Thanks for the suggestion! Done.

Copy link
Contributor

@anandolee anandolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ghost ghost merged commit 52fee0e into protocolbuffers:master Dec 11, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants