Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove C++11 features in io_win32.cc #3536

Merged
merged 2 commits into from
Aug 21, 2017
Merged

Remove C++11 features in io_win32.cc #3536

merged 2 commits into from
Aug 21, 2017

Conversation

liujisi
Copy link
Contributor

@liujisi liujisi commented Aug 21, 2017

  • Use scoped_array instead of unique_ptr.
  • Do not use string::front() and string::back()

@liujisi
Remove C++11 features in io_win32.cc
4aadcd3 
- Use scoped_array instead of unique_ptr.
- Do not use string::front() and string::back()
@liujisi liujisi requested a review from xfxyjwf August 21, 2017 20:17
@liujisi
Copy link
Contributor Author

liujisi commented Aug 21, 2017

Fixes #3533

@liujisi liujisi merged commit 92d768c into protocolbuffers:3.4.x Aug 21, 2017
@jrandalldemllo
Copy link

Getting VS10 build error for v3.4.1
Line 198 contains range based for loop syntax. Posted build error log in #3533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfxyjwf xfxyjwf xfxyjwf approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liujisi @jrandalldemllo @xfxyjwf @googlebot