Added Python to Travis build and clarified setup instructions. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok looks like tests are passing. :) |
|
|
||
| You need to export this variable before running setup.py script to build and | ||
| install the extension. You must also set the variable at runtime, otherwise | ||
| You must set this variable at runtime, before running your program, otherwise |
There was a problem hiding this comment.
So the flag is not needed when running the tests?
There was a problem hiding this comment.
Exactly, the tests set it automatically when --cpp_implementation is specified:
https://github.com/google/protobuf/blob/master/python/setup.py#L162
|
LGTM |
haberman
added a commit
that referenced
this pull request
Apr 10, 2015
Added Python to Travis build and clarified setup instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xfxyjwf
Hopefully this PR will pass right away in Travis, but if not I'll iterate and fix it. :)