Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podsvirov CMake changes backported to 3.0.x #2530

Closed
wants to merge 3 commits into from

Conversation

rpavlik
Copy link

@rpavlik rpavlik commented Dec 22, 2016

These are CMake changes, including an essential bugfix for protobuf_MODULE_COMPATIBLE, originally found in #1865 by @podsvirov - all I did was a git rebase --onto to get them on the 3.0.x branch.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@bazel-io
Copy link

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rpavlik
Copy link
Author

rpavlik commented Dec 22, 2016

I previously had the CLA signed (via employer) - I have an invite that I accepted back on august 3, 2015 to authorized-google-contributors. I suspect the fact that we switched to Google Apps, err, GSuite, since then might be causing the confusion with the CLA verification. (The google account I previously was using with this email prior to migration is now only identified as rpavliksensics a t gmail, and I can see the group on that account...)

[edit: CLA re-signed, new group is google-cla on the domain sensics.com]

@acozzette
Copy link
Member

ok to test

@acozzette
Copy link
Member

retest this please (talking to the Jenkins bot)

@acozzette
Copy link
Member

@rpavlik Actually I believe we are no longer really maintaining the 3.0.x branch and we likely won't be making any more releases in the 3.0.x series. In that case is there any particular reason you need to backport these fixes?

@rpavlik
Copy link
Author

rpavlik commented Jan 5, 2017

I signed it!

@rpavlik
Copy link
Author

rpavlik commented Jan 5, 2017

I wasn't sure what the branch maintenance policy was - it didn't appear to be laid out clearly anywhere (nor did anything newer than 3.0.0 show up on Google Developers page when I checked), and I assumed the presence of a 3.0.x branch, in the absence of other guidance, was then a stable release. Fine by me if no more 3.0.x releases occur, (I've actually switched to 3.1.x in the meantime) but then it probably should be documented somewhere :D (release notes of the downloads in GitHub would be one place to start...)

@xfxyjwf xfxyjwf closed this May 23, 2018
copybara-service bot pushed a commit that referenced this pull request Nov 21, 2022
This intends to be a first step solving issue #10965 and #2530. It just updates bazel skylib to version 1.3.0.

Closes #10979

COPYBARA_INTEGRATE_REVIEW=#10979 from Clement-Jean:skylib-update 607e249
PiperOrigin-RevId: 490013583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants