-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podsvirov CMake changes backported to 3.0.x #2530
Conversation
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I previously had the CLA signed (via employer) - I have an invite that I accepted back on august 3, 2015 to authorized-google-contributors. I suspect the fact that we switched to Google Apps, err, GSuite, since then might be causing the confusion with the CLA verification. (The google account I previously was using with this email prior to migration is now only identified as rpavliksensics a t gmail, and I can see the group on that account...) [edit: CLA re-signed, new group is google-cla on the domain sensics.com] |
ok to test |
retest this please (talking to the Jenkins bot) |
@rpavlik Actually I believe we are no longer really maintaining the 3.0.x branch and we likely won't be making any more releases in the 3.0.x series. In that case is there any particular reason you need to backport these fixes? |
I signed it! |
I wasn't sure what the branch maintenance policy was - it didn't appear to be laid out clearly anywhere (nor did anything newer than 3.0.0 show up on Google Developers page when I checked), and I assumed the presence of a 3.0.x branch, in the absence of other guidance, was then a stable release. Fine by me if no more 3.0.x releases occur, (I've actually switched to 3.1.x in the meantime) but then it probably should be documented somewhere :D (release notes of the downloads in GitHub would be one place to start...) |
These are CMake changes, including an essential bugfix for
protobuf_MODULE_COMPATIBLE
, originally found in #1865 by @podsvirov - all I did was agit rebase --onto
to get them on the 3.0.x branch.