Remove CMake downgrade workaround from Windows CI tests #19630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
force-pushed
the
windows-fix2
branch
from
261f98d to
9668cbd
Compare
This should fix some Windows tests that are failing to install a downgraded CMake version. I also fixed some of the Bazel examples tests. Two of the test runs seemed to be omitting a Bazel version and were inadvertently using Bazel 8.
acozzette
force-pushed
the
windows-fix2
branch
from
9668cbd to
5eacdbe
Compare
mkruskal-google
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some Windows tests that are failing to install a downgraded CMake version.
#test-continuous