Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packed reflection handling bug in edition 2023. #18405

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix packed reflection handling bug in edition 2023. #18405

merged 1 commit into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Fix packed reflection handling bug in edition 2023. 

    This is a very narrow edge case where touching a packed extension via generated APIs first, and then doing so reflectively will trigger a DCHECK.  Otherwise, reflective APIs will work but not use packed encoding for the extension.  This was likely a pre-existing bug dating back to proto3, where it would only be visible on custom options (the only extensions allowed in proto3).

To help qualify this and uncover similar issues, unittest.proto was migrated to editions.  This turned up some other minor issues in DebugString and python.

PiperOrigin-RevId: 675785611
    @mkruskal-google
    mkruskal-google committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    54b3a1d View commit details
    Browse the repository at this point in the history