Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cord handling in DynamicMessage and oneofs. #18374

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Commits on Sep 17, 2024

  1. Fix cord handling in DynamicMessage and oneofs.

    This fixes a memory corruption vulnerability for anyone using cord with dynamically built descriptor pools.
    zhangskz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cc228f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Move -Werror to our test/dev bazelrc files. (#17938)

        * Move -Werror to our test/dev bazelrc files.
    
        Putting it into BUILD files unintentionally forces it on all our downstream users.  Instead, we just want to enable this during testing and let them choose for themselves in their builds.
    
        Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.
    
        Closed #14714
    
        PiperOrigin-RevId: 666903224
    
        * Fix extra warnings on 28.x
    
        * Fix zlib issues on macos
    
        * Second try at zlib/macos issues
    
        * Only disable deprecated-non-prototype on macos-14
    zhangskz committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f38b4f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fba752d View commit details
    Browse the repository at this point in the history
  3. Fix test dependency

    mkruskal-google committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bb43bad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    98d34b2 View commit details
    Browse the repository at this point in the history
  5. Fix last upb warning

    mkruskal-google committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    52a541c View commit details
    Browse the repository at this point in the history