Removed specific MSVC settings when installing #17285
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing protobuf, it creates a different directory for CMake's config files when compiling with MSVC.
gRPC build on Windows
gRPC build on Linux and macOS
This is problematic because it requires conditionally setting its
protobuf_DIR
for different platforms:The original commit that made this based its choice on CMake's version 3.4, which not only is deprecated but is also based on a CMake version less than the one defined in the master file. Since then, CMake changed its behaviour, making this distinction unnecessary.