Fix windows 2019 staleness issue #17225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
requested review from
acozzette
and removed request for
a team and
acozzette
mkruskal-google
force-pushed
the
windows-2019-fix
branch
from
2456676 to
1050f45
Compare
mkruskal-google
changed the title
zhangskz
approved these changes
Jun 25, 2024
|
Can you update the PR description to mention the windows sandboxing and making the copy mutually exclusive for future reference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel on windows doesn't sandbox very well, and our old strategy for bootstrap staleness test was causing some non-deterministic failures. Before, we were creating multiple genrules copying the same batch of files, but only marking a specific one as the output of each. That works fine with proper sandboxing, but on windows can cause conflicts. With this change, each genrule limits its scope to only copy the 1 file it's meant to generate