Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building PHP extension on Windows #13097

Closed
wants to merge 1 commit into from
Closed

Enable building PHP extension on Windows #13097

wants to merge 1 commit into from

Conversation

Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Jun 17, 2023

This PR adds a config.w32 for the PHP extension and includes it in the tgz for PECL.
I used this to build php_protobuf.dll for PHP 8.2.7.
See phalcon/cphalcon#16318 (comment) for the request to build the extension and the result.

Please review and merge.

@Jan-E Jan-E requested review from a team as code owners June 17, 2023 20:28
@Jan-E Jan-E requested review from perezd and anandolee and removed request for a team June 17, 2023 20:28
@google-cla
Copy link

google-cla bot commented Jun 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 18, 2023
@Jan-E
Copy link
Contributor Author

Jan-E commented Jun 18, 2023

One of the comments above says I requested a review by @perezd and @anandolee
I never did that intentionally. Maybe it was somehow implicit. But if they could review the PR as well, they are of course very welcome.

@fowles fowles removed request for perezd and anandolee June 18, 2023 18:29
@fowles
Copy link
Contributor

fowles commented Jun 18, 2023

The system figures out likely people automatically. At this point no actions are needed from you. Odds are strong that we won't deal with the internal portions of landing this PR until Tuesday (Monday is a US holiday)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🅰️ safe for tests Mark a commit as safe to run presubmits over
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants