Migrate ruby release targets to genrule to work around Bazel 5 bug #11619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
added
ruby
release notes: no
jruby
mkruskal-google
requested review from
acozzette,
JasonLunn and
deannagarcia
and removed request for
a team,
acozzette and
JasonLunn
deannagarcia
approved these changes
Jan 20, 2023
mkruskal-google
force-pushed
the
ruby_release
branch
from
fcb656e to
9f44add
Compare
mkruskal-google
force-pushed
the
ruby_release
branch
from
3efb23d to
f91352a
Compare
ericsalo
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sh_binary doesn't treat its data dependencies correctly prior to Bazel 6 (see https://github.com/mkruskal-google/protobuf/pull/new/ruby_release)