Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix php lint #11417

Closed
wants to merge 1 commit into from
Closed

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Dec 28, 2022

fixes #11387

Addresses misc PHPDoc formatting issues.

Note: This does the bare minimum to suppress the errors. In some cases, most notably in CodedInputStream, the @param tag is still missing a typehint, and should have one added (in those cases, the variable is being passed in as int, but then used in the function as string, so it will take consideration)

@bshaffer bshaffer requested a review from a team as a code owner December 28, 2022 17:35
@bshaffer bshaffer requested review from anandolee and removed request for a team December 28, 2022 17:35
@anandolee anandolee requested review from haberman and removed request for anandolee December 28, 2022 23:36
@copybara-service copybara-service bot closed this in ade256e Jan 5, 2023
@bshaffer bshaffer deleted the fix-php-lint branch February 2, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP: Linting errors from Doctum
3 participants