-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .NET Native AOT warnings in Protobuf reflection #11128
Fix .NET Native AOT warnings in Protobuf reflection #11128
Conversation
Thanks. I'm on vacation for the weekend but will look on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Will run it through Kokoro and get it merged. Hopefully we can get the SDK update and tests in reasonably soon afterwards.
(The actual merge will be slightly delayed as we're sorting out internal mirroring for the C# codebase; I'll talk with the team about whether we should force-merge this one.) |
Just FYI, I haven't forgotten about this. We have some internal source control changes that I'm trying to get done before Christmas. They may slip into the New Year - but I definitely want to get this in. |
6ebecc7
to
51ed1bd
Compare
Rebased. |
Nice! @jskeet Are you able to give a rough estimate of when this will be available in a release? |
@JamesNK: I'm expecting it "pretty soon" if everything goes smoothly. I'd rather not be more precise than that and put the Protobuf team in a corner :) |
@JamesNK |
Please hold off on this for now - sorry about the mixed messages; too many teams involved! |
The fixes from #10978. This PR can be merged without updating the SDK. Will allow people to use Protobuf + AOT sooner rather than later.
When the repo is updated to .NET 7 or .NET 8, the original PR can be rebased on latest to add AOT analysis and provide some AOT smoke tests.
cc @jskeet