Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public modifiers to kotlin code #11068

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

deannagarcia
Copy link
Member

This is a fix for #10593 by cherrypicking #10599 and #10616.

@deannagarcia deannagarcia merged commit 7268e2f into protocolbuffers:21.x Nov 28, 2022
@jorgbrown jorgbrown mentioned this pull request Nov 29, 2022
@armiol
Copy link

armiol commented Dec 1, 2022

@deannagarcia Sorry for bringing this up again, but the problem still persists in v3.21.10 for me.

The thing is that for map fields, another generated method (named clear()) should have a public modifier. It seems to be in this line, where it's missing.

@alexander-yevsyukov FYI.

@armiol
Copy link

armiol commented Dec 1, 2022

@deannagarcia seems, that the issue was fixed for map in #10599. But for some reason, not all line changes were brought to 21.x branch when cherry-picking. I have left a comment in the original PR for your convenience.

Also, as previously, protobuf:master seems to be fine.

deannagarcia added a commit that referenced this pull request Dec 1, 2022
My previous attempt to do this #11068 (comment) missed this instance.
@deannagarcia
Copy link
Member Author

Sorry, not sure how the cherry-pick failed :( I'm working on a fix right now #11118

dand-oss pushed a commit to dand-oss/protobuf that referenced this pull request Mar 6, 2024
My previous attempt to do this protocolbuffers#11068 (comment) missed this instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants