Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP]Added missing files and fix phpext_protobuf_ptr export in pecl version #10689

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

Cotch22
Copy link
Contributor

@Cotch22 Cotch22 commented Sep 30, 2022

in order to compile php with protobuf from pecl.

now the pecl version of protobuf does not contain output to phpext_protobuf_ptr, causing me to manually add this code

extern zend_module_entry protobuf_module_entry;
#define phpext_protobuf_ptr &protobuf_module_entry

every time I rebuild PHP with --enable-protobuf

Please Add this file to PECL version.
https://pecl.php.net/package/protobuf

Thank!

@google-cla
Copy link

google-cla bot commented Sep 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Cotch22 Cotch22 changed the title Added missing files and fix phpext_protobuf_ptr export in pecl version [PHP]Added missing files and fix phpext_protobuf_ptr export in pecl version Sep 30, 2022
@deannagarcia
Copy link
Member

Thanks for this fix! If you sign the CLA I can get it merged for you.

@Cotch22
Copy link
Contributor Author

Cotch22 commented Oct 3, 2022

Thanks for this fix! If you sign the CLA I can get it merged for you.

Thanks. I have already signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants