Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] allow dynamic properties in Message #10594

Merged

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Sep 16, 2022

PHP 8.2 complains about Internal\Message setting dynamic properties:

Creation of dynamic property xxx is deprecated /usr/src/myapp/vendor/google/protobuf/src/Google/Protobuf/Internal/Message.php:153

Since the class uses dynamic properties a bit, enable them explicitly with an attribute.

PHP 8.2 complains about Internal\Message setting dynamic properties:

`Creation of dynamic property xxx is deprecated
/usr/src/myapp/vendor/google/protobuf/src/Google/Protobuf/Internal/Message.php:153`

Since the class uses dynamic properties a bit, enable them explicitly with an attribute.
@deannagarcia deannagarcia merged commit 8d0ddd9 into protocolbuffers:main Oct 3, 2022
@deannagarcia
Copy link
Member

Thanks for the fix!

@brettmc brettmc deleted the bugfix/php82-dynamic-properties branch October 4, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants