Upgrade to MSVC 2017, since 2015 is no longer supported #10437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Aug 22, 2022
|
is this a breaking change? Should this be part of the announcement for 22.x? |
|
Yes it's breaking in the sense that 2015 no longer works, but isn't this covered by our new support matrix? |
perhaps it's covered, but we should ensure people understand this is why, from a notification/awareness perspective. It should be explicitly communicated. |
This was announced specifically in https://developers.google.com/protocol-buffers/docs/news/2022-08-03#cpp-support-matrix |
|
I updated the PR description to be a little clearer here, does that help? |
mkruskal-google
changed the title
|
Perfect, thanks to you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2015 is no longer supported as per our support matrix. Specifically, our dependency on Abseil breaks this old compiler.