Reverting changes to ruby aarch64 build. #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perezd
approved these changes
Aug 11, 2022
marjoleinheyndrickx
pushed a commit
to marjoleinheyndrickx/protobuf
that referenced
this pull request
Aug 12, 2022
* Reverting changes to ruby aarch64 build. * Adding IN_DOCKER environment variable to prevent codegen * Pass the cmake-built protoc to the ruby runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our emulation docker image doesn't have ruby installed yet, and the old version of the test should work fine in the current state of our repo. The reason this wasn't caught in presubmits was that this test was only ever run as a continuous build.