avoid unused-parameter warning for c++ #10390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
reviewed
Aug 11, 2022
src/google/protobuf/arena.h
Outdated
| @@ -467,7 +467,7 @@ class PROTOBUF_EXPORT PROTOBUF_ALIGNAS(8) Arena final { | |||
| } | |||
|
|
|||
| template <typename U> | |||
| static Arena* GetArenaForAllocation(Rank2, const U* p) { | |||
| static Arena* GetArenaForAllocation(Rank2, const U*) { | |||
There was a problem hiding this comment.
inside google these are used. Please switch the suppression technique to
(void)p;
|
Suppression technique is switched to void cast, as suggested. |
fowles
approved these changes
Aug 16, 2022
|
Thanks for the PR. I will merge this after our CI system finishes |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…used-parameters avoid unused-parameter warning for c++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In clang these two functions with an unused parameter give a Wunused-parameter warning. By removing the parametername the warning disappears.