-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/issue 8101 #10268
Bugfix/issue 8101 #10268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well.
@tonydnewell thank you for this fix, but on our side there is still a similar bug open with this, e.g.: namespace "my.space._3" gets compiled to c# "my.space.3" which again causes an error. So also with "sub" namespaces after dots the numbers with an underscore should be preserved. thank you |
@nickwinger Thank you for your observation. I can see you've created a new issue #13482 |
here is the PR: #13504 |
…e-8101 Bugfix/issue 8101
Fix for #8101
When converting identifiers for C# camel case, handle the case where the input starts with "_<digit>" and preserve the underscore.
It does not alter existing behaviour for other identifiers: