Exposed more functions in FieldDescriptor and OneofDescriptor. #10102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haberman
requested changes
Jun 2, 2022
| /** | ||
| * @return boolean | ||
| */ | ||
| public function hasOptionalKeyword() |
There was a problem hiding this comment.
We should keep this function; it is useful.
You can implement it to match the C++ definition: http://google3/third_party/protobuf/descriptor.h;l=2387-2391;rcl=452188950
There was a problem hiding this comment.
Looks like the C++ implementation needs to rely on many fields and functions that don't exist here yet. I'll leave this function to you. I may get back here once I implement other functions that I need for my feature.
Having said that, IMHO, it's a broken function (for a while). Leaving it like this doesn't provide any good unless we provide the correct implementation soon.
fiboknacky
commented
Jun 9, 2022
Comment on lines
-251
to
-252
| $json_name = $proto->hasJsonName() ? $proto->getJsonName() : | ||
| lcfirst(implode('', array_map('ucwords', explode('_', $proto->getName())))); |
There was a problem hiding this comment.
This is redundant with the if clause below.
fiboknacky
force-pushed
the
update-fielddescriptor
branch
2 times, most recently
from
af2b22e to
88d57d4
Compare
fiboknacky
force-pushed
the
update-fielddescriptor
branch
from
88d57d4 to
0f1574a
Compare
haberman
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldDescriptor
getContainingOneofandgetRealContainingOneof.OneofDescriptor
isSyntheticwork.