Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constexpr defaulted default constructor of WrappedMutex causes compile errors #8492

Closed
przole opened this issue Apr 14, 2021 · 1 comment
Closed
Labels

Comments

@przole
Copy link

przole commented Apr 14, 2021

Version: 3.15.8
Language: C++

Windows 10 Enterprise 20H2 19042.867

Microsoft Visual Studio Enterprise 2019 Version 16.9.4

Steps to reproduce the behavior:

  1. Compile project with generated protobuf class causes:

Error defaulted default constructor cannot be constexpr because the corresponding implicitly declared default constructor would not be constexpr ...\include\google\protobuf\stubs\mutex.h 119

constexpr WrappedMutex() = default;
should be:
constexpr WrappedMutex() {}

przole pushed a commit to olejniczak/protobuf that referenced this issue Apr 14, 2021
@przole przole mentioned this issue Apr 14, 2021
fowles added a commit that referenced this issue Apr 14, 2021
#8492 constexpr defaulted default constructor of WrappedMutex
@elharo elharo added the c++ label Aug 25, 2021
@elharo
Copy link
Contributor

elharo commented Aug 25, 2021

fixed, I think

@elharo elharo closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants