Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CMake option to control whether or not RTTI is enabled #8361

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Create a CMake option to control whether or not RTTI is enabled #8361

merged 1 commit into from
Mar 2, 2021

Conversation

floriansimon1
Copy link

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@acozzette acozzette merged commit 1add7a7 into protocolbuffers:3.15.x Mar 2, 2021
@floriansimon1 floriansimon1 deleted the allow-disabling-rtti-from-cmake-command-line-3.15.x branch March 2, 2021 21:49
@dkorchynskyi-axcient
Copy link

@floriansimon1 why the RTTI is now disabled by default?

@floriansimon1
Copy link
Author

This is a mistake. I flipped the logic incompletely. I will submit a PR to address this ASAP

This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants