Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake option to define GOOGLE_PROTOBUF_NO_RTTI #5541

Closed
thomasgt opened this issue Jan 4, 2019 · 2 comments · Fixed by #8347
Closed

Add CMake option to define GOOGLE_PROTOBUF_NO_RTTI #5541

thomasgt opened this issue Jan 4, 2019 · 2 comments · Fixed by #8347

Comments

@thomasgt
Copy link

thomasgt commented Jan 4, 2019

What language does this apply to?
C++

Describe the problem you are trying to solve.
I am integrating Protobuf into a C++ project that does not use RTTI. I am building Protobuf from source (with CMake) and I'd like to be able to set the GOOGLE_PROTOBUF_NO_RTTI flag when I configure the build.

Describe the solution you'd like
I would like a CMake option to control whether or not GOOGLE_PROTOBUF_NO_RTTI gets defined.
@acozzette
Copy link
Member

That sounds like a good option to have; do you want to send a pull request with that change?

@thomasgt
Copy link
Author

thomasgt commented Jan 4, 2019

Sure!

@BSBandme BSBandme closed this as completed Jan 7, 2019
@floriansimon1 floriansimon1 mentioned this issue Feb 25, 2021
Merged
acozzette pushed a commit that referenced this issue Mar 2, 2021
@acozzette
Create a CMake option to control whether or not RTTI is enabled
a4e7b97 
This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541
acozzette pushed a commit that referenced this issue Mar 2, 2021
@acozzette
Create a CMake option to control whether or not RTTI is enabled
1add7a7 
This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a CMake option to control whether or not RTTI is enabled
3 participants
@acozzette @BSBandme @thomasgt