Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] deprecated collections usage (redux) #5335

Closed
tseaver opened this issue Nov 10, 2018 · 6 comments · Fixed by #6272
Closed

[python] deprecated collections usage (redux) #5335

tseaver opened this issue Nov 10, 2018 · 6 comments · Fixed by #6272
Assignees
Labels

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 10, 2018

What version of protobuf and what language are you using?
Version: master
Language: Python

What operating system (Linux, Windows, ...) and version?
Any

What runtime / compiler are you using (e.g., python version or gcc version)
Python 3.7.1

#5195 purported to fix #5135, but did so only for the deprecated usage in the google.protobuf.internal.containers module. Further changes are needed:

$ git grep -l "collections\.[A-Z]" "*.py"
python/google/protobuf/internal/_parameterized.py
python/google/protobuf/internal/message_test.py
python/google/protobuf/internal/well_known_types.py
python/google/protobuf/internal/well_known_types_test.py
@Evpok
Copy link

Evpok commented Feb 9, 2019

The alphas of 3.8 are getting out, any news on this?

@rok-povsic
Copy link

I'm seeing this in the logs:

/Users/travis/.pyenv/versions/3.7.2/lib/python3.7/site-packages/google/protobuf/descriptor.py:47: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from google.protobuf.pyext import _message

Looking forward to the fix.

@anandolee
Copy link
Contributor

A fix has been submitted in internal code with:

try:
  import collections.abc as collections_abc
except ImportError:
  import collections as collections_abc

Expect to see the fix in next release

@cclauss
Copy link

cclauss commented Oct 2, 2019

Python 3.8 release candidate 1 is available: https://www.python.org/download/pre-releases

@cclauss
Copy link

cclauss commented Oct 15, 2019

Python 3.8 was released yesterday https://www.python.org/downloads/release/python-380/

@yuvadm
Copy link

yuvadm commented Oct 30, 2019

A fix is pending, why isn't it being merged? #6272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants