-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw exception in Any.encode #4718
Comments
Does this happen with latest 3.6.0 release? |
`require': cannot load such file -- google/gax (LoadError) |
Yes, it reproduces with 3.6.0. Here's the full repro:
|
Unlike pack and unpack, Any.encode can only encode Any message. You should do:
|
However, segmentation fault is not what we want. Instead, exception should be thrown. We will fix that. |
Right, I understand that the repro case is contrived. This bug was opened exactly to turn a segfault into some reasonable Ruby-level error or exception. |
Fixed in #4885 |
I've added |
The following reliably crashes all three of ruby-2.2.7, ruby-2.3.4, and ruby-2.4.1 for me:
Here's the full output for ruby-2.2.7. Happy to provide the output for other rubies and attach the crash reports if it helps:
The text was updated successfully, but these errors were encountered: