Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descriptor.proto breaking changes caused by editions #16885

Closed
perezd opened this issue May 18, 2024 · 0 comments · Fixed by #16902
Closed

descriptor.proto breaking changes caused by editions #16885

perezd opened this issue May 18, 2024 · 0 comments · Fixed by #16902
Assignees
@zhangskz
Labels
untriaged auto added to all issues by default when created.

Comments

@perezd
Copy link
Contributor

perezd commented May 18, 2024

The original issue can be seen here: bufbuild/buf#2990
We'd propose marking all these removed fields as reserved as part of the 27.0 release.
@perezd perezd added the untriaged auto added to all issues by default when created. label May 18, 2024
copybara-service bot pushed a commit that referenced this issue May 20, 2024
@mkruskal-google @copybara-github
Mark removed Utf8Validation value reserved.
41b06f9 
See #16885

PiperOrigin-RevId: 635583798
@copybara-service copybara-service bot mentioned this issue May 20, 2024
Closed
copybara-service bot pushed a commit that referenced this issue May 20, 2024
@mkruskal-google @copybara-github
Mark removed Utf8Validation value reserved.
961a1b1 
See #16885

PiperOrigin-RevId: 635583798
copybara-service bot pushed a commit that referenced this issue May 20, 2024
@mkruskal-google @copybara-github
Mark deleted fields in descriptor.proto reserved
e11619a 
CLOSES #16885

PiperOrigin-RevId: 635583188
@copybara-service copybara-service bot mentioned this issue May 20, 2024
Merged
mkruskal-google added a commit that referenced this issue May 21, 2024
@mkruskal-google
Mark deleted fields in descriptor.proto reserved
d2da463 
CLOSES #16885

PiperOrigin-RevId: 635615643
deannagarcia pushed a commit to deannagarcia/protobuf that referenced this issue Jun 20, 2024
@mkruskal-google @deannagarcia
Mark deleted fields in descriptor.proto reserved
1e0c454 
CLOSES protocolbuffers#16885

PiperOrigin-RevId: 635615643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangskz zhangskz

Labels
untriaged auto added to all issues by default when created.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark deleted fields in descriptor.proto reserved protocolbuffers/protobuf
2 participants
@perezd @zhangskz