Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java generator: do not wrap comments in <pre> tags, do not escape html tags #13

Closed
estekhin opened this issue Sep 4, 2014 · 1 comment
Closed

java generator: do not wrap comments in <pre> tags, do not escape html tags #13

estekhin opened this issue Sep 4, 2014 · 1 comment
Labels
enhancement java

Comments

@estekhin
Copy link

estekhin commented Sep 4, 2014

Java generator wraps proto comments in <pre> tag and also html-escapes the comment value.

For example, this proto definition:

// <p>a comment</p>
message MyMessage {
}

is compiled into this Java source:

/**
 * Protobuf type {@code chronos.proto.MyMessage}
 *
 * <pre>
 * &lt;p&gt;a comment&lt;/p&gt;
 * </pre>
 */
public static final class MyMessage extends ...

Please change the generator behavior or add an option that will disable this behavior.
When it is enabled, proto comments should be converted into javadoc as is, without wrapping it in any additional tags or performing any escaping.
@cloudkey cloudkey mentioned this issue Feb 4, 2015
Closed
@xfxyjwf xfxyjwf added the java label Jan 19, 2016
@acozzette
Copy link
Member

I am going to go ahead and close this because we are cleaning up issues and I see that this one has not been updated in a long time. Feel free to reopen it if this is still a problem, though.

@jakiechris jakiechris mentioned this issue Nov 20, 2017
Closed
@E-HERO E-HERO mentioned this issue Dec 3, 2017
Closed
@ujmedia ujmedia mentioned this issue Jul 23, 2018
Closed
@catskul catskul mentioned this issue Aug 21, 2018
Closed
TeBoring pushed a commit to TeBoring/protobuf that referenced this issue Jan 19, 2019
@haberman
Merge pull request protocolbuffers#13 from cfallin/json-maps
535bc2f 
Fixed JSON parser issue: missing NUL byte in parse_number() in some code paths.
@arnow117 arnow117 mentioned this issue Apr 1, 2019
Closed
@sunbibei sunbibei mentioned this issue Sep 26, 2019
Closed
PierrickVoulet pushed a commit to PierrickVoulet/protobuf that referenced this issue Jun 6, 2020
Provide UT that reproduces issue protocolbuffers#13
b5068a5
@snehasinha13 snehasinha13 mentioned this issue Sep 30, 2020
Closed
@shaod2 shaod2 mentioned this issue May 3, 2021
Merged
@xianggao xianggao mentioned this issue Oct 27, 2021
Closed
@sin-zx sin-zx mentioned this issue Jan 18, 2022
Closed
@rong-lai rong-lai mentioned this issue Jul 25, 2023
Closed
rinarakaki pushed a commit to rinarakaki/protobuf that referenced this issue Aug 30, 2023
@haberman @copybara-github
Fixed MSAN warning by freeing the arena in ~InlinedArena().
81d27ec 
This fixes an MSAN warning of the form:

```
WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7fc964f2a597 in arena_findroot third_party/upb/upb/mem/arena.c:64:3
    #1 0x7fc964f2a597 in upb_Arena_Free third_party/upb/upb/mem/arena.c:211:7
    protocolbuffers#2 0x7fc9d2af0028 in std::__msan::unique_ptr<upb_Arena, void (*)(upb_Arena*)>::~unique_ptr() third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__memory/unique_ptr.h:277:7
    protocolbuffers#3 0x7fc9d2aef7a2 in ~Arena third_party/upb/upb/upb.hpp:70:7
    protocolbuffers#4 0x7fc9d2aef7a2 in ~InlinedArena third_party/upb/upb/upb.hpp:97:7
    protocolbuffers#5 0x7fc9d2aef7a2 in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1
    protocolbuffers#6 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5
    protocolbuffers#7 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11
    protocolbuffers#8 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30
    protocolbuffers#9 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44
    protocolbuffers#10 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc
    protocolbuffers#11 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10
    protocolbuffers#12 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73
    protocolbuffers#13 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10
    protocolbuffers#14 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44)
    protocolbuffers#15 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120

  Member fields were destroyed
    #0 0x562a7fb0b13d in __sanitizer_dtor_callback_fields third_party/llvm/llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:960:5
    #1 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:105:8
    protocolbuffers#2 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:97:7
    protocolbuffers#3 0x7fc9d2aef79a in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1
    protocolbuffers#4 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5
    protocolbuffers#5 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11
    protocolbuffers#6 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30
    protocolbuffers#7 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44
    protocolbuffers#8 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc
    protocolbuffers#9 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10
    protocolbuffers#10 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73
    protocolbuffers#11 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10
    protocolbuffers#12 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44)
    protocolbuffers#13 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120
```

PiperOrigin-RevId: 511849224
@M-Labedzki M-Labedzki mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement java
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acozzette @estekhin @xfxyjwf