Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf 4.21.9 python distribution missing LICENSE file #10936

Closed
zookae opened this issue Nov 8, 2022 · 1 comment
Closed

protobuf 4.21.9 python distribution missing LICENSE file #10936

zookae opened this issue Nov 8, 2022 · 1 comment
Assignees

Comments

@zookae
Copy link

zookae commented Nov 8, 2022

What version of protobuf and what language are you using?
Version: 4.21.9
Language: Python

What operating system (Linux, Windows, ...) and version?
Windows 11. Linux.

What runtime / compiler are you using (e.g., python version or gcc version)
Pip install only.

What did you do?
Download the protobuf python package:

mkdir _tmp
pip install -t _tmp protobuf==4.21.9
dir _tmp\protobuf-4.21.9.dist-info
dir _

Shows:

11/07/2022  04:08 PM    <DIR>          .
11/07/2022  04:08 PM    <DIR>          ..
11/07/2022  04:08 PM                 4 INSTALLER
11/07/2022  04:08 PM               540 METADATA
11/07/2022  04:08 PM            11,177 RECORD
11/07/2022  04:08 PM                 0 REQUESTED
11/07/2022  04:08 PM               100 WHEEL
               5 File(s)         11,821 bytes
               2 Dir(s)  408,855,826,432 bytes free

What did you expect to see
The LICENSE file included in the dist-info list.

What did you see instead?
No LICENSE file.

Anything else we should know about your project / environment
We use a script to gather licenses for python packages we include when shipping our products. Protobuf is one of the packages that does not include a license file for us to gather, requiring extra manual steps to collect. Ideally the solution would fix this for all protobuf versions going forward as we've encountered the same problem with many previous protobuf releases. Thanks!

Related issues: #8904 and #7536 (#7536)

@zookae zookae added the untriaged auto added to all issues by default when created. label Nov 8, 2022
@acozzette acozzette removed the untriaged auto added to all issues by default when created. label Nov 8, 2022
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 22, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 22, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 23, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 23, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 23, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 23, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 23, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Nov 23, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 1, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 1, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 1, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 1, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 2, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 5, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 490350846
copybara-service bot pushed a commit to protocolbuffers/upb that referenced this issue Dec 5, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 493060514
@deannagarcia
Copy link
Member

Thanks for this report. protocolbuffers/upb@92dbe4b should fix the issue and the LICENSE file should be in the wheel for the next release.

deannagarcia added a commit to protocolbuffers/upb that referenced this issue Dec 5, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 493060514
deannagarcia added a commit to deannagarcia/upb that referenced this issue Dec 5, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 493060514
deannagarcia added a commit to protocolbuffers/upb that referenced this issue Dec 5, 2022
Addresses protocolbuffers/protobuf#10936.

This requires updating to the newest version of rules_python to use the new py_wheel API that includes a parameter for extra distinfo files

PiperOrigin-RevId: 493060514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants